Merged
Conversation
shati-patel
approved these changes
Sep 14, 2022
Contributor
shati-patel
left a comment
There was a problem hiding this comment.
Teeny comment (which you're welcome to ignore 😛), otherwise I think this looks good.
(Disclaimer: this isn't a particularly in-depth review, since I was at the mobbing session where we got this working. Feel free to wait for an "independent" review too)
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a new variant analysis view that will support live results and will eventually replace the current remote queries view.
Mobbed with @koesie10 @robertbrignull and @shati-patel
As part of this we:
Checklist
N/A - internal feature:
ready-for-doc-reviewlabel there.