Skip to content

Add new variant analysis view#1506

Merged
charisk merged 3 commits intomainfrom
charisk/variant-analysis-view
Sep 14, 2022
Merged

Add new variant analysis view#1506
charisk merged 3 commits intomainfrom
charisk/variant-analysis-view

Conversation

@charisk
Copy link
Copy Markdown
Contributor

@charisk charisk commented Sep 13, 2022

Add a new variant analysis view that will support live results and will eventually replace the current remote queries view.

Mobbed with @koesie10 @robertbrignull and @shati-patel

As part of this we:

  • Added a new configuration setting to control whether to enable new variant analysis live result flows.
  • Added a new web view that will be used to render the outcome of a variant analysis.
  • Added a new command that will be used to easily load up the view with some mock data. The command will be removed when we have implemented the required functionality.

Checklist

N/A - internal feature:

  • CHANGELOG.md has been updated to incorporate all user visible changes made by this pull request.
  • Issues have been created for any UI or other user-facing changes made by this pull request.
  • [Maintainers only] If this pull request makes user-facing changes that require documentation changes, open a corresponding docs pull request in the github/codeql repo and add the ready-for-doc-review label there.

@charisk charisk requested review from a team as code owners September 13, 2022 16:07
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Teeny comment (which you're welcome to ignore 😛), otherwise I think this looks good.

(Disclaimer: this isn't a particularly in-depth review, since I was at the mobbing session where we got this working. Feel free to wait for an "independent" review too)

Comment thread extensions/ql-vscode/package.json Outdated
charisk and others added 2 commits September 14, 2022 12:38
Co-authored-by: Shati Patel <42641846+shati-patel@users.noreply.github.com>
@charisk charisk enabled auto-merge (squash) September 14, 2022 11:42
@charisk charisk merged commit 2e9c0c3 into main Sep 14, 2022
@charisk charisk deleted the charisk/variant-analysis-view branch September 14, 2022 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants