Support for rewriting hiera datadir from multiple backends#32
Merged
kpaulisse merged 2 commits intogithub:masterfrom Dec 14, 2016
Merged
Conversation
When using hiera-eyaml with a hiera.yaml like: ~~~yaml --- :backends: - eyaml - yaml :eyaml: :datadir: '/etc/puppet/code/environments/production/hieradata' :yaml: :datadir: '/etc/puppet/code/environments/production/hieradata' ... ~~~ Octocatalog-diff was rewriting only the yaml (and/or json) datadir and not other backends datadir. This changes rewrites all datadir from all declared backends. Signed-off-by: Brice Figureau <brice@daysofwonder.com>
kpaulisse
approved these changes
Dec 14, 2016
Contributor
kpaulisse
left a comment
kpaulisse
left a comment
There was a problem hiding this comment.
👍 Thank you very much for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This pull request introduces support for multiple hiera backend
datadirrewriting.The current code only allows the fixed hiera backend yaml and json. For people using other backends like for instance hiera_eyaml, the
datadirkey of the backend section wouldn't be rewritten.This change will make sure to rewrite all defined backend
datadirentries.Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests.