Split arguments added for ENC#112
Merged
kpaulisse merged 2 commits intogithub:masterfrom May 10, 2017
waldiTM:puppet-arguments-enc
Merged
Split arguments added for ENC#112kpaulisse merged 2 commits intogithub:masterfrom waldiTM:puppet-arguments-enc
kpaulisse merged 2 commits intogithub:masterfrom
waldiTM:puppet-arguments-enc
Conversation
The arguments for puppet invocations are not longer explicitely split on white-spaces. This means that only one argument is added for ENC, while this should be two (--node_terminus and --external_nodes). Just properly split the arguments.
kpaulisse
reviewed
May 10, 2017
| if @options[:enc] | ||
| raise Errno::ENOENT, "Did not find ENC as expected at #{@options[:enc]}" unless File.file?(@options[:enc]) | ||
| cmdline << "--node_terminus=exec --external_nodes=#{Shellwords.escape(@options[:enc])}" | ||
| cmdline << "--node_terminus=exec" |
Contributor
There was a problem hiding this comment.
Our rubocop rules will flag this as needing single quotes (mostly trying to keep the codebase consistent, and chose to use format similar to Puppet). If you could fix that up, this looks fine to me and I'll merge. Thanks!
kpaulisse
approved these changes
May 10, 2017
Contributor
|
@waldiTM Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
The arguments for puppet invocations are not longer explicitely split on
white-spaces. This means that only one argument is added for ENC, while
this should be two (--node_terminus and --external_nodes). Just
properly split the arguments.
Checklist
rakein your checkout directory, or review the CI job triggered whenever you push to a pull request.rake coverage:specor ignoring untestable sections of code with# :nocovcomments. If you need help getting to 100% coverage please ask; however, don't just submit code with no tests..gemfile into the vendor/cache directory./cc [related issues] [teams and individuals, making sure to mention why you're CC-ing them]