Skip to content

Cleans up and clarifies gitignore contribution guidelines#4843

Merged
wirecat merged 3 commits into
mainfrom
clarified_contribution
Apr 17, 2026
Merged

Cleans up and clarifies gitignore contribution guidelines#4843
wirecat merged 3 commits into
mainfrom
clarified_contribution

Conversation

@wirecat
Copy link
Copy Markdown
Collaborator

@wirecat wirecat commented Apr 17, 2026

Reasons for making this change

Adds clarification around our expectations for contributions and how contributions will be handled when they don't meet our requirements.

Updates template to lean into our contribution guidelines.

Cleans up duplicate wording around our contribution guidelines.

Links to documentation supporting these rule changes

NA

If this is a new template

Link to application or project’s homepage: github.com/github/gitignore 😄

Merge and Approval Steps

  • Confirm that you've read the contribution guidelines and ensured your PR aligns
  • Ensure CI is passing
  • Get a review and Approval from one of the maintainers

Adds clarification around our expectations for contributions and
how contributions will be handled when they don't meet our requirements.

Updates template to lean into our contribution guidelines.

Cleans up duplicate wording around our contribution guidelines.
@wirecat wirecat requested a review from a team as a code owner April 17, 2026 20:39
Copilot AI review requested due to automatic review settings April 17, 2026 20:39
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the repository’s contribution documentation to reduce duplication, clarify expectations for .gitignore template submissions, and align the PR template with the contribution process.

Changes:

  • Adds a prominent pointer in README.md to the contribution guidelines and replaces duplicated inline guidelines with a link.
  • Clarifies and expands the rules in CONTRIBUTING.md (scope, duplicates, section placement, and closure expectations).
  • Updates .github/PULL_REQUEST_TEMPLATE.md to prompt for required contribution metadata and reinforce guideline compliance.
Show a summary per file
File Description
README.md Adds an early reference to the guidelines and replaces the full “Contributing guidelines” block with a link to CONTRIBUTING.md.
CONTRIBUTING.md Expands/clarifies contribution requirements (scope, duplication, placement) and adds language about closing non-compliant PRs.
.github/PULL_REQUEST_TEMPLATE.md Adds a homepage link section and tightens the checklist messaging around meeting guidelines.

Copilot's findings

Tip

Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

  • Files reviewed: 3/3 changed files
  • Comments generated: 4

Comment thread README.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread .github/PULL_REQUEST_TEMPLATE.md
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
dooleydevin
dooleydevin previously approved these changes Apr 17, 2026
Removed the checklist item for ensuring CI is passing. We don't really have CI as of yet and it's confusing to list that requirement. If we do add CI, we'll make it required instead of adding it to the template checklist.
@wirecat wirecat merged commit 9d7511b into main Apr 17, 2026
2 checks passed
@wirecat wirecat deleted the clarified_contribution branch April 17, 2026 20:46
@NoahGreer NoahGreer mentioned this pull request May 17, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants