Skip to content

Remove non-existent README property#99

Merged
williammartin merged 1 commit intomainfrom
wm/remove-gitignore
Apr 4, 2025
Merged

Remove non-existent README property#99
williammartin merged 1 commit intomainfrom
wm/remove-gitignore

Conversation

@williammartin
Copy link
Copy Markdown
Collaborator

Description

Accidentally lost this commit from #89 because I didn't realise that it hadn't been merged into main when I force pushed. Whoops!

Copilot AI review requested due to automatic review settings April 4, 2025 12:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the non-existent "gitignore_template" property from the README documentation to correct inaccuracies.

  • Removed the obsolete property bullet under repository initialization instructions.

Tip: If you use Visual Studio Code, you can request a review from Copilot before you push from the "Source Control" tab. Learn more

@williammartin williammartin merged commit 07f6d11 into main Apr 4, 2025
16 checks passed
@williammartin williammartin deleted the wm/remove-gitignore branch April 4, 2025 13:01
DaleSeo pushed a commit to DaleSeo/github-mcp-server that referenced this pull request Oct 24, 2025
* updates details for brave search

* resolves server-tool enumeration

Docker's mcp-registry/internal/mcp/client.go file pulls values from the env.example key when standing up the server, prior to requesting the tool list. The mcp-registry expects stdio to be the transport whereon tools are listed, but the "http" example in server.yaml causes the MCP Server to launch with an HTTP Transport, thus breaking the flow.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants