Skip to content

Fix the entitlements team cache when there are multiple instances of GitHub in use. #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jasonmacgowan merged 4 commits into from
Jan 29, 2024
+4 −4
Merged

Fix the entitlements team cache when there are multiple instances of GitHub in use. #30

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
398e3af
Fix the entitlements team cache when there are multiple instances of …
chrisgavin Jan 28, 2024
52bbcbc
Merge branch 'main' into fix-team-cache-for-multiple-instances
jasonmacgowan Jan 29, 2024
1fb63d3
Use `org_signature` method to determine the cache path to use.
chrisgavin Jan 29, 2024
9785e42
Bump the version to 0.5.3.
chrisgavin Jan 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions lib/entitlements/backend/github_team/service.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,8 +35,9 @@ class TeamNotFound < RuntimeError; end
def initialize(addr: nil, org:, token:, ou:, ignore_not_found: false)
super
Entitlements.cache[:github_team_members] ||= {}
Entitlements.cache[:github_team_members][org] ||= {}
@team_cache = Entitlements.cache[:github_team_members][org]
Entitlements.cache[:github_team_members][addr] ||= {}
Entitlements.cache[:github_team_members][addr][org] ||= {}
@team_cache = Entitlements.cache[:github_team_members][addr][org]
Comment thread
chrisgavin marked this conversation as resolved.
Outdated
end

# Read a single team identified by its slug and return a team object.
Expand Down