fix an example in authentication-in-a-workflow - #4517
Merged
Conversation
actions/labeler now recommends to use the `pull_request_target` event. With the `pull_request` event, `GITHUB_TOKEN` sometimes lacks write permissions (e.g. pull requests from forked repository or from dependabot) and actions/labeler doesn't work well. ref. actions/labeler#90 ref. https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
Contributor
|
@shogo82148 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
1 similar comment
Contributor
|
@shogo82148 Thanks so much for opening a PR! I'll get this triaged for review ⚡ |
janiceilene
added
actions
ethanpalm
approved these changes
Mar 17, 2021
ethanpalm
left a comment
ethanpalm
left a comment
Contributor
There was a problem hiding this comment.
Thanks for opening this PR, @shogo82148! The change looks great and I'll get it merged as soon as all checks are passing ✨
Thanks for your contribution and helping to improve the GitHub docs!
Contributor
|
Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why:
actions/labeler now recommends to use the
pull_request_targetevent.With the
pull_requestevent,GITHUB_TOKENsometimes lacks write permissions (e.g. pull requests from forked repository or from dependabot)and actions/labeler doesn't work well.
ref. actions/labeler#90
ref. https://github.blog/2020-08-03-github-actions-improvements-for-fork-and-pull-request-workflows/#improvements-for-public-repository-forks
What's being changed:
update the example workflow of actions/labeler.
Check off the following: