Call out how write:packages requires repo scope on PATs

[dgholz]

Why:

Closes #2660

What's being changed:

The docs used to recommend removing repo scope when creating a PAT with write:packages, but it's not possible. So, clearly call that out, and when linking to the security best practices, also call out which practice to follow.

Check off the following:

• I have reviewed my changes in staging. (look for the deploy-to-heroku link in your pull request, then click View deployment)
• For content changes, I have reviewed the localization checklist (feels wordy)
• For content changes, I have reviewed the Content style guide for GitHub Docs.

[welcome]

Thanks for opening this pull request! A GitHub docs team member should be by to give feedback soon. In the meantime, please check out the contributing guidelines.

[dgholz]

I see in the preview that the warning appears twice.

I don't know the best way to get it to appear only once when both reusables are included in the same page. Should I worry about the warning appearing when either reusable appears by itself? If not, which reusable should the warning appear in?

I feel like, if it appears in only one place, it should be in reusables.package_registry.authenticate_with_pat_for_container_registry and not data reusables.package_registry.authenticate-to-container-registry-steps (matching where the original warning appeared)

[janiceilene]

@dgholz Thanks so much for opening a PR! I'll get this triaged for review ⚡

[jmarlena]

Heads up, given the security related content I'm requesting some input from other stakeholders. ⚡

[jmarlena]

Note: Since this PR was opened there have been some changes to this feature. GitHub Container Registry now supports using the GITHUB_TOKEN for GitHub Actions workflows, which improves the security experience here since users don't have to rely on a PAT in a workflow.

I also noted a workaround for only selecting the write:packages scope with this url: https://github.com/settings/tokens/new?scopes=write:packages.

[jmarlena]

@dgholz Thank you for your contribution here! 🚢 This looks ready to ship!

[github-actions]

Thanks very much for contributing! Your pull request has been merged 🎉 You should see your changes appear on the site in approximately 24 hours. If you're looking for your next contribution, check out our help wanted issues ⚡