Java: path sanitizer for replace, replaceAll, and matches#18646
Merged
jcogs33 merged 10 commits intogithub:mainfrom Mar 18, 2025
Merged
Java: path sanitizer for replace, replaceAll, and matches#18646jcogs33 merged 10 commits intogithub:mainfrom
replace, replaceAll, and matches#18646jcogs33 merged 10 commits intogithub:mainfrom
Conversation
jcogs33
changed the title
replace', replaceAll, and matches`replace, replaceAll, and matches
jcogs33
force-pushed
the
jcogs33/java/directory-chars-path-sanitizer
branch
from
c33e03d to
a88e541
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
jcogs33
force-pushed
the
jcogs33/java/directory-chars-path-sanitizer
branch
from
6b5cce0 to
d0207c6
Compare
jcogs33
force-pushed
the
jcogs33/java/directory-chars-path-sanitizer
branch
from
17d20e6 to
41aeb87
Compare
owen-mc
requested changes
Mar 13, 2025
Contributor
owen-mc
left a comment
owen-mc
left a comment
There was a problem hiding this comment.
Mostly looking good. A few suggestions and one thing that I think is wrong.
added 6 commits
March 17, 2025 15:07
owen-mc
approved these changes
Mar 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds a path injection sanitizer for calls to
replace,replaceAll, andmatchesthat make sure/,\,..are not in the path.Consideration
isReplaceTarget,isReplaceAllTarget, andisMatchesTarget.