Skip to content

CI: Configure Python analysis #3112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
henrymercer merged 6 commits into from
Sep 15, 2025
Merged

CI: Configure Python analysis #3112

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
793fe17
CI: Configure Python analysis
henrymercer Sep 15, 2025
73ead84
Reorder strategy properties
henrymercer Sep 15, 2025
61b8b63
Only upload a single matrix case for JS
henrymercer Sep 15, 2025
8105843
Specify `paths-ignore` for other languages
henrymercer Sep 15, 2025
bce0fa7
Remove build mode from matrix
henrymercer Sep 15, 2025
1069ace
Update .github/workflows/codeql.yml
henrymercer Sep 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions .github/codeql/codeql-actions-config.yml
View file
Open in desktop

This file was deleted.

0 .github/codeql/codeql-config.yml → .github/codeql/codeql-config-javascript.yml
View file
Open in desktop
File renamed without changes.
20 changes: 14 additions & 6 deletions .github/workflows/codeql.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ jobs:
id: init
with:
languages: javascript
config-file: ./.github/codeql/codeql-config.yml
config-file: ./.github/codeql/codeql-config-javascript.yml
tools: ${{ matrix.tools }}
# confirm steps.init.outputs.codeql-path points to the codeql binary
- name: Print CodeQL Version
Expand All @@ -108,11 +108,16 @@ jobs:
with:
category: "/language:javascript"


analyze-actions:
analyze-other:
runs-on: ubuntu-latest

strategy:
matrix:
include:
- language: actions
build-mode: none
- language: python
build-mode: none
fail-fast: false
Copy link

Copilot AI Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The fail-fast: false should be placed before the matrix definition for better readability and to follow GitHub Actions convention of placing strategy-level options before matrix definitions.

Suggested change
matrix:
include:
- language: actions
build-mode: none
- language: python
build-mode: none
fail-fast: false
fail-fast: false
matrix:
include:
- language: actions
build-mode: none
- language: python
build-mode: none

Copilot uses AI. Check for mistakes.

permissions:
Expand All @@ -125,9 +130,12 @@ jobs:
- name: Initialize CodeQL
uses: ./init
with:
languages: actions
config-file: ./.github/codeql/codeql-actions-config.yml
Copy link
Copy Markdown
Member

@mbg mbg Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMHO we should keep this and make it part of the matrix. Then we can have a Python config that filters out the test file. We could do the same with config in the matrix as well.

Copy link
Copy Markdown
Contributor Author

@henrymercer henrymercer Sep 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think since we don't yet have anything that needs to be language specific, it might be more readable to have a single config embedded into the workflow file. I've pushed a commit to add that.

languages: ${{ matrix.language }}
build-mode: ${{ matrix.build-mode }}
config: >
queries:
- uses: security-and-quality
- name: Perform CodeQL Analysis
uses: ./analyze
with:
category: "/language:actions"
category: "/language:${{ matrix.language }}"
Loading