Skip to content

Refactor handling of feature flags #1284

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
aeisenberg merged 11 commits into from
Oct 12, 2022
Merged

Refactor handling of feature flags #1284

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
e5c3375
Refactor handling of feature flags
aeisenberg Oct 5, 2022
b16314e
Address comments from review
aeisenberg Oct 6, 2022
6de05e4
Rename `FeatureFlag` -> `Feature`
aeisenberg Oct 6, 2022
5915e70
Address comments from review
aeisenberg Oct 6, 2022
b27aed7
Extract GitHubFeatureFlags to a separate class
aeisenberg Oct 6, 2022
1a17c59
More renaming
aeisenberg Oct 7, 2022
919e4ca
Merge remote-tracking branch 'upstream/main' into aeisenberg/ff-refac…
aeisenberg Oct 7, 2022
6c869f8
Fix typos
aeisenberg Oct 7, 2022
701cea3
More renaming
aeisenberg Oct 11, 2022
43c3ed9
More feature flag renaming
henrymercer Oct 11, 2022
34d48f8
Merge remote-tracking branch 'upstream/main' into aeisenberg/ff-refac…
aeisenberg Oct 12, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/codeql.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.js.map
View file
Open in desktop

Large diffs are not rendered by default.

51 changes: 22 additions & 29 deletions lib/codeql.test.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/codeql.test.js.map
View file
Open in desktop

Large diffs are not rendered by default.

3 changes: 1 addition & 2 deletions lib/config-utils.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/config-utils.js.map
View file
Open in desktop

Large diffs are not rendered by default.

43 changes: 41 additions & 2 deletions lib/feature-flags.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/feature-flags.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading