[GHSA-74fj-2j2h-c42q] Exposure of sensitive information in follow-redirects#7472
Closed
ljharb wants to merge 1 commit intoljharb/advisory-improvement-7472from
Closed
[GHSA-74fj-2j2h-c42q] Exposure of sensitive information in follow-redirects#7472ljharb wants to merge 1 commit intoljharb/advisory-improvement-7472from
ljharb wants to merge 1 commit intoljharb/advisory-improvement-7472from
Conversation
github-actions
Bot
changed the base branch from
main
to
ljharb/advisory-improvement-7472
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the GHSA advisory metadata for follow-redirects to reflect that the cross-host cookie/header leak behavior (and thus the vulnerability) begins at a later version than previously recorded.
Changes:
- Update the advisory
modifiedtimestamp. - Narrow the affected version range by changing the
introducedversion from0to0.0.6.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updates
Comments
Empirical POC-based runtime testing confirms follow-redirects 0.0.1-0.0.5 do not leak Cookie headers on cross-host redirects. Versions 0.0.1-0.0.3 rebuild the redirect via a bare
module.exports[__proto__].get(redirectUrl)call that forwards only the URL, so the original requests Cookie header never reaches the second hop. Versions 0.0.4-0.0.5 start forwarding some header state but still do not trigger the cross-host leak path. Cross-host header forwarding (and thus the vulnerability) landed in 0.0.6.