Ignore archived metadata - #14761
Draft
Caleb-T-Owens wants to merge 4 commits into
Draft
Conversation
The archived metadata flag was primarily intended so we could keep metadata for PRs that got integrated up stream. At one point in time when we infered workspace state from the vb.toml, if this flag wasn’t set, we could accidentally include extra commits. These days however, we should only use the target_commit_id to determine what is or isn’t shown. The archived flag shouldn’t hide commits that should be shown due to their topology
Caleb-T-Owens
force-pushed
the
caleb/next-project-meta-migration-step
branch
3 times, most recently
from
July 23, 2026 10:17
9dc74a5 to
d9a5569
Compare
Base automatically changed from
caleb/next-project-meta-migration-step
to
master
July 23, 2026 10:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The archived metadata flag was primarily intended so we could keep metadata for PRs that got integrated up stream.
At one point in time when we infered workspace state from the vb.toml, if this flag wasn’t set, we could accidentally include extra commits.
These days however, we should only use the target_commit_id to determine what is or isn’t shown. The archived flag shouldn’t hide commits that should be shown due to their topology
This is part 2 of 2 in a stack made with GitButler: