Add support for CircleCI#449
Merged
TheSnoozer merged 2 commits intogit-commit-id:masterfrom Nov 3, 2019
andrebrait:master
Merged
Add support for CircleCI#449TheSnoozer merged 2 commits intogit-commit-id:masterfrom andrebrait:master
TheSnoozer merged 2 commits intogit-commit-id:masterfrom
andrebrait:master
Conversation
TheSnoozer
reviewed
Nov 3, 2019
| * @see <a href="https://docs.gitlab.com/ce/ci/variables/predefined_variables.html">GitlabCIVariables</a> | ||
| */ | ||
| public static boolean isActiveServer(Map<String, String> env) { | ||
| return env.containsKey("CI"); |
Collaborator
There was a problem hiding this comment.
That's a good one! Thanks for the fix!
Collaborator
|
Hello, Changes look good for me and thanks for the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This adds support for CircleCI for this plugin. It's useful for getting branch name and revision number when running on CircleCI.
Contributor Checklist
mvn clean packagecheckstylecoding style definition:mvn clean verify -Pcheckstyle -Dmaven.test.skip=true -BNotes
I couldn't find any tests that tested that sort of thing, hence why I didn't add any.