Fix VAD min silence argument parsing - #3963
Merged
danbev merged 1 commit intoAug 3, 2026
Merged
Conversation
chupakobra6
marked this pull request as ready for review
July 31, 2026 10:58
danbev
approved these changes
Aug 3, 2026
Member
|
I've opened #3966 for the failing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
--vad-min-silence-duration-ms(-vsd) parsing inwhisper-vad-speech-segments.The option was incorrectly assigned to
vad_min_speech_duration_msinstead ofvad_min_silence_duration_ms. As a result, the requested silence duration was ignored and the minimum speech duration was overwritten.Testing
whisper-vad-speech-segmentstest-vadjfk.wavand a 1000 ms minimum silence duration