fix(error-reporting): Silence ValidationError as user input error (CLI-1FN) - #1361
Open
sentry[bot] wants to merge 3 commits into
Open
fix(error-reporting): Silence ValidationError as user input error (CLI-1FN)#1361sentry[bot] wants to merge 3 commits into
sentry[bot] wants to merge 3 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously,
ValidationErrorinstances were not explicitly handled by theclassifySilencedfunction inpackages/cli/src/lib/error-reporting.ts. This meant that user input errors, such as providing a non-existent directory to a sourcemap command, were being reported to Sentry as crashes rather than being silenced as expected user-facing errors.This change addresses the issue by:
'user_input_error'to theSilenceReasontype.classifySilencedto return'user_input_error'when the error is an instance ofValidationError.This ensures that
ValidationErrors are now correctly silenced, preventing them from polluting Sentry crash reports while still allowing their volume to be tracked via thecli.error.silencedmetric.Related unit tests in
test/lib/error-reporting.test.tshave been updated to reflect this new behavior, asserting thatValidationErrors are now silenced rather than captured.Fixes CLI-1FN