Replace pkg_resources with importlib.resources - #22
Merged
georgkrause merged 1 commit intoNov 19, 2024
Merged
Conversation
Owner
|
@moi15moi Thank you for the patch! Its appreciated and I am going to merge it. However, since its breaking support for python 3.8, I have to make sure the release is done after its EOL. And we need to bump the minimal required python version to 3.9, and remove the tests. I am going to handle this in my next dev session. |
pkg_resources is deprecated as an API, so let's replace it with importlib.resources. See https://setuptools.pypa.io/en/latest/pkg_resources.html
georgkrause
force-pushed
the
Replace-pkg_resources-with-import-importlib.resources
branch
from
November 6, 2024 12:44
5f62d71 to
cfcdcb2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pkg_resources is deprecated as an API, so let's replace it with importlib.resources. See https://setuptools.pypa.io/en/latest/pkg_resources.html