Allow disabling LDAP form login while keeping HTTP Basic enabled - #278
Open
jusabatier wants to merge 1 commit into
Open
Allow disabling LDAP form login while keeping HTTP Basic enabled#278jusabatier wants to merge 1 commit into
jusabatier wants to merge 1 commit into
Conversation
Contributor
Author
|
Just tested it, and it works well. With |
Contributor
Author
|
Possible to merge, or something remain to fix ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
LDAP authentication currently enables both HTTP Basic and form login.
This makes it difficult to keep LDAP Basic Auth available for technical clients while avoiding an extra LDAP login option for browser users.
Changes
This PR adds a new
disableLdapFormLoginoption undergeorchestra.gateway.security.Default behavior is unchanged.
When
disableLdapFormLoginis set totrue:Backward compatibility
The default value is
false, so existing configurations keep the current behavior:Testing note
I was able to validate the code-level behavior locally, but I have not yet been able to run a full deployment/integration test in real conditions.
I am currently away and will only be able to perform deployment-level testing next week. Feedback on the approach is welcome in the meantime.