fix(ssh): properly handle GIT_SSH_COMMAND#2119
Open
anondeveg wants to merge 1 commit intofolke:mainfrom
Open
Conversation
Properly handle GIT_SSH_COMMAND so it respects Git's core.sshCommand setting. size/s
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First things first, i really appreciate your work on this excellent plugin. the codebase was intuitive, clean, and modularized enough for me to get to speed fast and start implementing the fix!
Description
this pull request fixed #2012
where if the user set a custom git.core.sshCommand lazy.nvim would just ignore it and use the hardcoded value of "ssh"
what i did:
0 separated command arguments into a separate SSH_OPTIONS variable
1 checked if there is an environment variable that should have the highest precedence, and if there is i would assing it to GIT_SSH_COMMAND
2 else if the user configured a custom git.sshCommand i would acknowledge that and assign it to GIT_SSH_COMMAND
3 else GIT_SSH_COMMAND would default to "ssh"
Related Issue(s)
Screenshots