[camera_web] Re: Support for camera stream on web#7950
Open
TecHaxter wants to merge 92 commits into
Open
Conversation
…d before expecting mock response
…d before expecting mock response
…d before expecting mock response
…d before expecting mock response
…d before expecting mock response
…d before expecting mock response
…m, and used window.animationFrames
…le height and width in takeFrame
…seOffScreenCanvas
Author
|
Ready for review |
ditman
reviewed
Apr 20, 2026
ditman
left a comment
Member
There was a problem hiding this comment.
This is very cool! I don't work on this nowadays, but here's some extra comments:
- Would
requestVideoFrameCallbackbe better than requestAnimationCallback? - Would it be possible to use
MediaStreamTrackProcessorif available inwindow? There's an example here: Video Frame Processing on the Web – WebAssembly, WebGPU, WebGL, WebCodecs, WebNN, and WebTransport
Anyway, very cool. Thanks for reviving this!
Author
|
Thanks for the valuable comments Ditman and the suggestion about MediaStreamTrackProcessor :) |
Contributor
|
@TecHaxter – we love thoughtful, polite contributors. Thanks for helping out! |
|
is any update on this PR? |
…ollow wasm comp, moved copyVideoFrameToBufferAndGetStride in camera_service with exception handling, cleaned _triggerVideoStreamTrackProcessorLoop in camera
…rAndGetStride camera service tests
Collaborator
|
From triage: @mdebbar it looks from discussion above like this is ready for a hopefully final review round. |
This comment was marked as off-topic.
This comment was marked as off-topic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR aims to provide support for strartImageStream and stopImageStream on Web.
#92460
Based on #6944 from the archived plugins repository
Pre-launch Checklist
dart format.)[shared_preferences]pubspec.yamlwith an appropriate new version according to the [pub versioning philosophy], or this PR is [exempt from version changes].CHANGELOG.mdto add a description of the change, [following repository CHANGELOG style].///).POV: my first PR on a public repo
Contains required commits from the PR #6443, resolves unnecessary 202 commits