[material_ui] Add ReorderableListView.separated constructor - #12779
Draft
krolmic wants to merge 1 commit into
Draft
[material_ui] Add ReorderableListView.separated constructor#12779krolmic wants to merge 1 commit into
krolmic wants to merge 1 commit into
Conversation
Ports the Material half of flutter/flutter#190131 per flutter/flutter#188444: a reorderable list with separators between items, mirroring ListView.separated.
krolmic
marked this pull request as draft
September 8, 2026 08:39
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the ReorderableListView.separated constructor to ReorderableListView, allowing the creation of reorderable lists with separators between items. It includes an example implementation, comprehensive unit tests, and a pending changelog entry. A critical syntax error was identified in the example file where EdgeInsets was omitted from the padding property.
| final Color evenItemColor = colorScheme.primary.withValues(alpha: 0.15); | ||
|
|
||
| return ReorderableListView.separated( | ||
| padding: const .symmetric(horizontal: 40.0), |
Contributor
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ports the Material half of flutter/flutter#190131 per flutter/flutter#188444: a reorderable list with separators between items, mirroring ListView.separated.
This ports the Material half of flutter/flutter#190131 to
material_ui,following flutter/flutter#188444 (Material is frozen in
flutter/flutter). The widgets half (
SliverReorderableList.separated,which this constructor wraps) remains in flutter/flutter#190131. The API
example wraps each
ListTilein its own keyedMaterialso tilebackgrounds move with their tiles during a drag, addressing
review feedback
from @Piinks on the original PR (
tileColoris painted by the nearestancestor
Material, per theListTiledocumentation).This PR depends on
SliverReorderableList.separatedlanding influtter/flutter (flutter/flutter#190131). Once that API is in a Flutter
release CI can use, I'll bump
flutter:in pubspec.yaml and markthis ready for review.
Fixes flutter/flutter#76706
Pre-Review Checklist
[shared_preferences]///).If you need help, consider asking for advice on the #hackers-new channel on Discord.
Note: The Flutter team is currently trialing the use of Gemini Code Assist for GitHub. Comments from the
gemini-code-assistbot should not be taken as authoritative feedback from the Flutter team. If you find its comments useful you can update your code accordingly, but if you are unsure or disagree with the feedback, please feel free to wait for a Flutter team member's review for guidance on which automated comments should be addressed.Footnotes
Regular contributors who have demonstrated familiarity with the repository guidelines only need to comment if the PR is not auto-exempted by repo tooling. ↩ ↩2