Skip to content

Adopt to the breaking changes in FluentAssertions 8 - #4

Merged
dennisdoomen merged 1 commit into
fluentassertions:mainfrom
dennisdoomen:upgrade-to-assertionchain
Dec 2, 2024
Merged

Adopt to the breaking changes in FluentAssertions 8#4
dennisdoomen merged 1 commit into
fluentassertions:mainfrom
dennisdoomen:upgrade-to-assertionchain

Conversation

@dennisdoomen

@dennisdoomen dennisdoomen commented Nov 30, 2024 •
edited
Loading

Copy link
Copy Markdown
Member

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.

jnyrup
jnyrup reviewed Nov 30, 2024
View reviewed changes
Comment thread Src/FluentAssertions.DataSets/DataSetAssertions.cs Outdated
@dennisdoomen
dennisdoomen force-pushed the upgrade-to-assertionchain branch 4 times, most recently from 595f99f to 6fe5f86 Compare November 30, 2024 21:37
@dennisdoomen dennisdoomen mentioned this pull request Nov 30, 2024
Merged
@dennisdoomen
dennisdoomen requested a review from jnyrup November 30, 2024 21:43
jnyrup
jnyrup approved these changes Dec 2, 2024
View reviewed changes
Comment thread Tests/Approval.Tests/Approval.Tests.csproj
Comment thread Src/FluentAssertions.DataSets/DataSetAssertions.cs Outdated
@dennisdoomen
dennisdoomen force-pushed the upgrade-to-assertionchain branch from 6fe5f86 to 122c5b3 Compare December 2, 2024 19:22
@dennisdoomen dennisdoomen changed the title Adopt to the breaking changes in FluentAssertions 7 Adopt to the breaking changes in FluentAssertions 8 Dec 2, 2024
@dennisdoomen
dennisdoomen merged commit daac80f into fluentassertions:main Dec 2, 2024
@dennisdoomen
dennisdoomen deleted the upgrade-to-assertionchain branch December 2, 2024 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@dennisdoomen @jnyrup