feat: add default propagators - #2740
Conversation
| public withDefaultPropagators(argProps: ArgProps = ArgProp.Alias | ArgProp.Value | ArgProp.Shape): this { | ||
| const idx = BuiltInIndex.default(); | ||
| for(const i of idx.pure) { | ||
| const sig = idx.entries.find(e => Identifier.matches(i, e.name))?.sig; |
There was a problem hiding this comment.
I did not use BuiltInIndex.get() to be namespace-save
There was a problem hiding this comment.
revised in 2.15.2 its now supporting this
| for(const i of idx.pure) { | ||
| const sig = idx.entries.find(e => Identifier.matches(i, e.name))?.sig; | ||
| if(!sig){ | ||
| continue; |
There was a problem hiding this comment.
What should we do if there is no signature information?
Simply join all incoming taints, if there are any?
There was a problem hiding this comment.
go to top? 🙈 like then it is a general unknown and it should be at least treated like a sigdb entry with no more info
| argTaints: arg, | ||
| condition: (_, taints) => { | ||
| const taintDomains = taints.map(t => this.domain.create(t)); | ||
| return AbstractDomain.joinAll(taintDomains).value as AbstractValue<Domain>; |
There was a problem hiding this comment.
I should probably make this customizable, as discussed
| public withDefaultPropagators(argProps: ArgProps = ArgProp.Alias | ArgProp.Value | ArgProp.Shape): this { | ||
| const idx = BuiltInIndex.default(); | ||
| for(const i of idx.pure) { | ||
| const sig = idx.entries.find(e => Identifier.matches(i, e.name))?.sig; |
There was a problem hiding this comment.
revised in 2.15.2 its now supporting this
| for(const i of idx.pure) { | ||
| const sig = idx.entries.find(e => Identifier.matches(i, e.name))?.sig; | ||
| if(!sig){ | ||
| continue; |
There was a problem hiding this comment.
go to top? 🙈 like then it is a general unknown and it should be at least treated like a sigdb entry with no more info
| typeof path === 'string' && NetworkProtocolRegex.test(path) ? NetworkInput : FileInput; | ||
|
|
||
| export const securityAnalysis = new TaintAnalysisDefinition('security', securityDomain) | ||
| .withDefaultPropagators() |
There was a problem hiding this comment.
not the javascript event system suppressdefault 😭
There was a problem hiding this comment.
and i was hoping one could get taint-analysis semantic labels and then write:
.on(GeneralClass.PureComputer, ....)
No description provided.