Ensure that all async generators are explicitly closed - #30
Merged
Conversation
Contributor
Author
|
This is part of my efforts to clean up asyncgen usage in httpx/httpcore to get MCP working with Trio. |
Contributor
Author
|
I am also working on PRs against httpcore and httpx, see encode/httpcore#1019 |
Contributor
Author
|
Could I ask for a new release too? 🙏 |
Owner
|
Ah yes, will do |
Merged
Owner
Contributor
Author
Much obliged! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If this is not done, it will be up to the event loop's asyncgen finalizer to do the closing, and there's no telling when it will happen. Additionally, Trio will emit a warning whenever the finalizer detects an unclosed async generator.