Skip to content

[2.x] perf(core): mitigate n+1 on notifications index#4817

Open
DavideIadeluca wants to merge 1 commit into
flarum:2.xfrom
glowingblue:di/notifications-n-plus-1
Open

[2.x] perf(core): mitigate n+1 on notifications index#4817
DavideIadeluca wants to merge 1 commit into
flarum:2.xfrom
glowingblue:di/notifications-n-plus-1

Conversation

@DavideIadeluca

@DavideIadeluca DavideIadeluca commented Jul 16, 2026

Copy link
Copy Markdown
Contributor

Fixes #0000

Changes proposed in this pull request:

Reviewers should focus on:
Review this along side #4816. Maybe take inspiration from both PR's and create a new PR yourself with a mixture of both fixes and close ours

Screenshot

Necessity

  • Has the problem that is being solved here been clearly explained?
  • If applicable, have various options for solving this problem been considered?
  • For core PRs, does this need to be in core, or could it be in an extension?
  • Are we willing to maintain this for years / potentially forever?

Confirmed

  • Frontend changes: tested on a local Flarum installation.
  • Backend changes: tests are green (run composer test).
  • Core developer confirmed locally this works as intended.
  • Tests have been added, or are not appropriate here.

Required changes:

  • Related documentation PR: (Remove if irrelevant)

@DavideIadeluca DavideIadeluca changed the title perf(core): mitigate n+1 on notifications index [2.x] perf(core): mitigate n+1 on notifications index Jul 16, 2026
@DavideIadeluca
DavideIadeluca marked this pull request as ready for review July 16, 2026 14:22
@DavideIadeluca
DavideIadeluca requested a review from a team as a code owner July 16, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant