feat(vsock): Add VIRTIO_RING_F_EVENT_IDX support - #5872
Merged
ShadowCurse merged 3 commits intoMay 18, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5872 +/- ##
=======================================
Coverage 82.90% 82.90%
=======================================
Files 277 277
Lines 30053 30058 +5
=======================================
+ Hits 24914 24919 +5
Misses 5139 5139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Manciukic
force-pushed
the
vsock-notif-suppression
branch
2 times, most recently
from
May 12, 2026 14:59
f469021 to
7ce0e6e
Compare
Manciukic
marked this pull request as ready for review
May 12, 2026 14:59
Manciukic
added
the
Status: Awaiting review
JackThomson2
previously approved these changes
May 13, 2026
ShadowCurse
reviewed
May 14, 2026
Contributor
|
LGTM. I wonder if we have any way of testing this, other than the improved performance numbers. |
Manciukic
force-pushed
the
vsock-notif-suppression
branch
from
May 14, 2026 17:10
51047e1 to
0c7b8d5
Compare
ilstam
previously approved these changes
May 15, 2026
JackThomson2
previously approved these changes
May 15, 2026
Remove commented-out code and unused VSOCK_NUM_QUEUES import. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Enables notification suppression in vsock device through EVENT_IDX feature: - Advertise VIRTIO_RING_F_EVENT_IDX in AVAIL_FEATURES - Call enable_notif_suppression() on activate when EVENT_IDX is negotiated - Use pop_or_enable_notification() in process_rx/process_tx - Gate return value with prepare_kick() so signal_used_queues is only called for queues that actually need a kick, preserving the existing trigger_queues coalescing optimization Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Add a CHANGELOG.md entry documenting the new notification suppression support in the virtio-vsock device via the EVENT_IDX virtio feature. Signed-off-by: Riccardo Mancini <mancio@amazon.com>
Manciukic
force-pushed
the
vsock-notif-suppression
branch
from
May 15, 2026 11:40
0e4ed33 to
05c4846
Compare
ilstam
approved these changes
May 15, 2026
ShadowCurse
enabled auto-merge (rebase)
May 15, 2026 15:37
ShadowCurse
approved these changes
May 15, 2026
micz010
approved these changes
May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Enables notification suppression in vsock device through EVENT_IDX feature:
Reason
Notif suppression is used in net and block as well, and achieves up to 2x better h2g throughput on MMIO with no g2h regression. On PCI, h2g is up to 10% better on Graviton, g2h is up to 20% better on AMD.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.