fix(cpu-template): remove CPUID.07H.02H from GNR 5.10 template - #5690
Merged
JamesC1305 merged 2 commits intoFeb 17, 2026
Merged
Conversation
Subleaf 07H.02H contains some extended feature information on granite rapids CPUs. Our template accidentally tried to mask this out despite it not being passed through by KVM on 5.10 hosts. This led to fatal errors when trying to spawn a VM using this template. To fix, just remove subleaf 07H.02H from the GNR_TO_T2_5.10 template. This will not affect the security posture of this instance combination, it will just fix the error when applying the template Signed-off-by: James Curtis <jxcurtis@amazon.co.uk>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5690 +/- ##
=======================================
Coverage 83.13% 83.13%
=======================================
Files 277 277
Lines 29376 29376
=======================================
Hits 24421 24421
Misses 4955 4955
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
zulinx86
approved these changes
Feb 17, 2026
Manciukic
approved these changes
Feb 17, 2026
JamesC1305
enabled auto-merge (rebase)
February 17, 2026 12:20
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Subleaf 07H.02H has been removed from
GNR_TO_T2_5.10.jsontemplate.Reason
Subleaf 07H.02H contains some extended feature information on granite rapids CPUs. Our template accidentally tried to mask this out despite it not being passed through by KVM on 5.10 hosts. This led to fatal errors when trying to spawn a VM using this template.
To fix, just remove subleaf 07H.02H from the GNR_TO_T2_5.10 template. This will not affect the security posture of this instance combination, it will just fix the error when applying the template
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkbuild --allto verify that the PR passesbuild checks on all supported architectures.
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.