function barrier in npzreadarray and introduce readheader - #44
Conversation
Codecov Report
@@ Coverage Diff @@
## master #44 +/- ##
==========================================
+ Coverage 85.29% 86.15% +0.85%
==========================================
Files 1 1
Lines 170 195 +25
==========================================
+ Hits 145 168 +23
- Misses 25 27 +2
Continue to review full report at Codecov.
|
fhs
left a comment
There was a problem hiding this comment.
Thanks!
It looks ok from a high level. I didn't look at it in detail -- I stopped using Julia years ago and I've lost a lot of my knowledge and also Julia has changed. I'm looking for other people to help review these PRs.
|
Thank you for your package! Could you tag a new version by commenting |
|
Error while trying to register: Register Failed |
Ok, commented |
|
Comments on pull requests will not trigger Registrator, as it is disabled. Please try commenting on a commit or issue. |
This PR does two things:
Headertype parametric and concrete: this seems to cut down on allocations while reading arraysOn master:
After this PR:
The difference in run-time is marginal.
readheaderthat returns the header. This might be convenient to get theeltypeandsizeof the array without reading it in (eg. to pre-allocate an array of the correct size). This function is not exported.