added version 2 support for reading - #32
Merged
Merged
Conversation
fhs
requested changes
Feb 26, 2019
fhs
left a comment
fhs
left a comment
Owner
There was a problem hiding this comment.
npzwritearray should check if length(dict) overflows UInt16 or UInt32. If it overflows Uint32, it's an error. Otherwise, if it overflows UInt16, it should use v2 format. Since this PR is focused on reading, maybe we'll do this in a separate PR.
Can you also add a test? Maybe add a small v2 format npz file in the test directory and try to read it. Thanks.
| end | ||
| @compat b = read!(f, Vector{UInt8}(undef, length(Version))) | ||
| if b != Version | ||
| if b[2] != Version[2] |
Owner
There was a problem hiding this comment.
I think we can safely remove this check. We don't care about minor version number. If version 2.1 ever comes out, it'll probably be backward compatible 2.0.
Contributor
Author
|
I added a small test file for v2 and removed the testing of the minor version. Thanks! |
fhs
approved these changes
Feb 26, 2019
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I introduced support for reading version 2 *.npy files. This should fix:
#31
I hope you like it like this.