Skip to content
This repository was archived by the owner on Dec 5, 2022. It is now read-only.

Implement generic bucket - #94

Merged
fgrehm merged 1 commit into
fgrehm:masterfrom
gnustavo:generic-bucket
Apr 7, 2014
Merged

Implement generic bucket#94
fgrehm merged 1 commit into
fgrehm:masterfrom
gnustavo:generic-bucket

Conversation

@gnustavo

Copy link
Copy Markdown
Contributor

This is my attempt to implement a "generic" bucket that I can use to cache downloads I perform with wget. It's working on my Puppet provisioned vagrant environment but I'm not sure I've understood cachier's architecture fully since I can only baby-talk Ruby. :)

In particular, I'm not sure I did the right thing on the Generic.capability method.

What do you think?

This bucket must be explicitly enabled and may be useful for users
wanting a generic caching mechanism that they can use directly instead
of via some predefined packaging system.

For instance, this enables one to implement a cache for packages
downloaded via wget or curl.
@fgrehm fgrehm added this to the v1.0 milestone Mar 25, 2014
@fgrehm

fgrehm commented Mar 25, 2014

Copy link
Copy Markdown
Owner

Show de bola :-)

The code LGTM but I need to find some time to test it, if someone else with commit access is able to give it a go, please go ahead and merge!

/cc @cromulus as you seem the be interested on it since the early days of the plugin on GH-4

@gnustavo

Copy link
Copy Markdown
Contributor Author

Legal, tchê! :-)

I think with this feature here and with another one I'm proposing elsewhere my vagrant/puppet workflow will get superfast!

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed out an end here :-P I'm fixing and merging this now. Thanks a lot!

fgrehm added a commit that referenced this pull request Apr 7, 2014
fgrehm added a commit that referenced this pull request Apr 7, 2014
@fgrehm
fgrehm merged commit a63156e into fgrehm:master Apr 7, 2014
@gnustavo
gnustavo deleted the generic-bucket branch April 7, 2014 11:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants