Skip to content

feat: add definitions #84

Merged
Shinigami92 merged 5 commits intofaker-js:migrate-to-typescriptfrom
ericjeker:add-definitions
Jan 11, 2022
Merged

feat: add definitions #84
Shinigami92 merged 5 commits intofaker-js:migrate-to-typescriptfrom
ericjeker:add-definitions

Conversation

@ericjeker
Copy link
Copy Markdown
Contributor

No description provided.

@Shinigami92 Shinigami92 self-requested a review January 11, 2022 11:12
@Shinigami92 Shinigami92 added the p: 1-normal Nothing urgent label Jan 11, 2022
Comment thread src/index.ts Outdated
Comment thread src/index.ts Outdated
Comment thread src/index.ts Outdated
@Shinigami92
Copy link
Copy Markdown
Member

I will merge this now and potentially we could improve a bit in base branch
But this is really needed for many other modules

@damienwebdev Maybe you want to post review this one extra 🤔

@Shinigami92 Shinigami92 merged commit 90192db into faker-js:migrate-to-typescript Jan 11, 2022
This was referenced Jan 11, 2022
Shinigami92 added a commit that referenced this pull request Jan 11, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 added a commit that referenced this pull request Jan 12, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 added a commit that referenced this pull request Jan 12, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 added a commit that referenced this pull request Jan 13, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Shinigami92 added a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
damienwebdev pushed a commit that referenced this pull request Jan 14, 2022
Co-authored-by: Shinigami <chrissi92@hotmail.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants