-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: faker.finance.pin() #695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9ee0924
feat: pin number function
ejcheng e190df8
test: add finance.pin() tests
ejcheng 0e7c026
docs: incorporate @xDivisionByZerox's fix
ejcheng 1a17045
fix: add pkuczynski's simplification of function and tests
ejcheng 42248c4
fix: make test name more clear
ejcheng 00a0df5
fix: provide example where length is given
ejcheng 2109588
feat: throws error when length < 1, add test for error
ejcheng 60b3f94
Update src/finance.ts
ejcheng d56b65e
Update src/finance.ts
ejcheng 5fbf279
fix: new error message in test
ejcheng 80007a5
Merge branch 'main' into feat_pin
Shinigami92 a8abe45
fix: add @Shinigami92's suggestion (change error to FakerError)
ejcheng 421299e
Merge branch 'main' into feat_pin
Shinigami92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.