-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat: add book module #2949
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Shinigami92
merged 21 commits into
faker-js:next
from
cieslarmichal:feature/book-module
Oct 10, 2024
Merged
feat: add book module #2949
Changes from 6 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7dc1ba7
feat: add book module
cieslarmichal 16cc6e4
feat: add book polish locale
cieslarmichal 607694b
chore: generate locales
cieslarmichal 07c8fe4
docs: add book docs page
cieslarmichal b9d70c5
feat: add tests
cieslarmichal e01996e
feat: add snapshot tests
cieslarmichal 0c953cd
chore: address review comments
cieslarmichal 47cfe77
feat: improve data quality
cieslarmichal ffee57d
feat: improve data quality v2
cieslarmichal 11191b0
Merge branch 'next' into feature/book-module
matthewmayer 309726c
chore: fix typo in genre
cieslarmichal fee988e
Merge branch 'next' into feature/book-module
cieslarmichal a04b62c
Merge branch 'next' into feature/book-module
cieslarmichal 272e259
feat: add more book titles and authors data
cieslarmichal 2106531
Merge branch 'next' into feature/book-module
cieslarmichal 4561d0a
Merge branch 'next' into feature/book-module
matthewmayer 279e886
Merge branch 'next' into feature/book-module
ST-DDT a8447d3
Merge branch 'next' into feature/book-module
ST-DDT 1708ebf
Merge branch 'next' into feature/book-module
ST-DDT 5b3374e
Merge branch 'next' into feature/book-module
ST-DDT 76987e0
Merge branch 'next' into feature/book-module
Shinigami92 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| import type { LocaleEntry } from './definitions'; | ||
|
|
||
| /** | ||
| * The possible definitions related to books. | ||
| */ | ||
| export type BookDefinition = LocaleEntry<{ | ||
| author: string[]; | ||
| format: string[]; | ||
| genre: string[]; | ||
| series: string[]; | ||
| title: string[]; | ||
| publisher: string[]; | ||
|
ST-DDT marked this conversation as resolved.
|
||
| }>; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,102 @@ | ||
| export default [ | ||
| 'Adams, Clifford R. (Clifford Rose)', | ||
| 'Alcott, Louisa May', | ||
| 'Austen, Jane', | ||
| 'Balzac, Honoré de', | ||
| 'Barrie, J. M. (James Matthew)', | ||
| 'Baum, L. Frank (Lyman Frank)', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Bhide, Shivaram Parashuram', | ||
| 'Brock, C. E. (Charles Edmund)', | ||
| 'Brontë, Charlotte', | ||
| 'Buckley, Theodore Alois', | ||
| 'Burnett, Frances Hodgson', | ||
| 'Burroughs, Edgar Rice', | ||
| 'Burton, Richard Francis, Sir', | ||
| 'Butler, Samuel', | ||
| 'Carroll, Lewis', | ||
| 'Cervantes Saavedra, Miguel de', | ||
| 'Chambers, Robert W. (Robert William)', | ||
| 'Chekhov, Anton Pavlovich', | ||
| 'Chesterton, G. K. (Gilbert Keith)', | ||
| 'Christie, Agatha', | ||
| 'Conrad, Joseph', | ||
| 'Dante Alighieri', | ||
| 'Defoe, Daniel', | ||
| 'Derbyshire, Charles E.', | ||
| 'Dickens, Charles', | ||
| 'Doré, Gustave', | ||
| 'Dostoyevsky, Fyodor', | ||
| 'Doyle, Arthur Conan', | ||
| 'Dumas, Alexandre', | ||
| 'Eliot, George', | ||
| 'Eliot, T. S. (Thomas Stearns)', | ||
| 'Fielding, Henry', | ||
| 'Fitzgerald, F. Scott (Francis Scott)', | ||
| 'Forster, E. M. (Edward Morgan)', | ||
| 'Garnett, Constance', | ||
| 'Gaskell, Elizabeth Cleghorn', | ||
| 'Gilman, Charlotte Perkins', | ||
| 'Goethe, Johann Wolfgang von', | ||
| 'Grimm, Jacob', | ||
| 'Grimm, Wilhelm', | ||
| 'Hapgood, Isabel Florence', | ||
| 'Hardy, Thomas', | ||
| 'Hawthorne, Nathaniel', | ||
| 'Homer', | ||
| 'Hotten, John Camden', | ||
| 'Howard, Robert E. (Robert Ervin)', | ||
| 'Hugo, Victor', | ||
| 'Ibsen, Henrik', | ||
| 'Indrajit, Bhagavanlal', | ||
| 'James, Henry', | ||
| 'Jowett, Benjamin', | ||
| 'Joyce, James', | ||
| 'Kafka, Franz', | ||
| 'Kipling, Rudyard', | ||
| 'Lang, Andrew', | ||
| 'Levy, Oscar', | ||
| 'London, Jack', | ||
| 'Lovecraft, H. P. (Howard Phillips)', | ||
| 'Machiavelli, Niccolò', | ||
| 'Marriott, W. K. (William Kenaz)', | ||
| 'Marx, Karl', | ||
| 'Maude, Aylmer', | ||
| 'Maude, Louise', | ||
| 'Maupassant, Guy de', | ||
| 'Melville, Herman', | ||
| 'Merrill, Frank T.', | ||
| 'Milne, A. A. (Alan Alexander)', | ||
| 'Montgomery, L. M. (Lucy Maud)', | ||
| 'Morley, Henry', | ||
| 'Nietzsche, Friedrich Wilhelm', | ||
| 'Ormsby, John', | ||
| 'Packard, Vance', | ||
| 'Plato', | ||
| 'Poe, Edgar Allan', | ||
| 'Pope, Alexander', | ||
| 'Potter, Beatrix', | ||
| 'Rizal, José', | ||
| 'Russell, Bertrand', | ||
| 'Schopenhauer, Arthur', | ||
| 'Scott, Walter', | ||
| 'Shakespeare, William', | ||
| 'Shaw, Bernard', | ||
| 'Shelley, Mary Wollstonecraft', | ||
| 'Smollett, T. (Tobias)', | ||
| 'Stevenson, Robert Louis', | ||
| 'Stoker, Bram', | ||
| 'Swift, Jonathan', | ||
| 'Thoreau, Henry David', | ||
| 'Tolstoy, Leo', | ||
| 'Twain, Mark', | ||
| 'Vatsyayana', | ||
| 'Verne, Jules', | ||
| 'Von Arnim, Elizabeth', | ||
| 'Wagner, Richard', | ||
| 'Ward, Grady', | ||
| 'Wells, H. G. (Herbert George)', | ||
| 'Widger, David', | ||
| 'Wilde, Oscar', | ||
| 'Wodehouse, P. G. (Pelham Grenville)', | ||
| 'Wyllie, David', | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| export default ['Audiobook', 'Ebook', 'Hardcover', 'Paperback']; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| export default [ | ||
|
matthewmayer marked this conversation as resolved.
|
||
| 'Biography/Autobiography', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Classic', | ||
| 'Comic/Graphic Novel', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Crime/Detective', | ||
| 'Essay', | ||
| 'Fable', | ||
| 'Fairy tale', | ||
| 'Fanfiction', | ||
| 'Fantasy', | ||
| 'Fiction in verse', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Fiction narrative', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Folklore', | ||
| 'Historical fiction', | ||
| 'Horror', | ||
| 'Humor', | ||
| 'Legend', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Metafiction', | ||
| 'Mystery', | ||
| 'Mythology', | ||
| 'Mythopoeia', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Narrative nonfiction', | ||
| 'Realistic fiction', | ||
| 'Reference book', | ||
| 'Science fiction', | ||
| 'Short story', | ||
| 'Speech', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Suspense/Thriller', | ||
| 'Tall tale', | ||
|
matthewmayer marked this conversation as resolved.
Outdated
|
||
| 'Textbook', | ||
| 'Western', | ||
| ]; | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| /* | ||
| * This file is automatically generated. | ||
| * Run 'pnpm run generate:locales' to update. | ||
| */ | ||
| import type { BookDefinition } from '../../..'; | ||
| import author from './author'; | ||
| import format from './format'; | ||
| import genre from './genre'; | ||
| import publisher from './publisher'; | ||
| import series from './series'; | ||
| import title from './title'; | ||
|
|
||
| const book: BookDefinition = { | ||
| author, | ||
| format, | ||
| genre, | ||
| publisher, | ||
| series, | ||
| title, | ||
| }; | ||
|
|
||
| export default book; |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.