refactor(locale)!: remove unused global locale faker instance#2789
refactor(locale)!: remove unused global locale faker instance#2789
Conversation
✅ Deploy Preview for fakerjs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2789 +/- ##
==========================================
- Coverage 99.95% 99.95% -0.01%
==========================================
Files 2972 2971 -1
Lines 212564 212553 -11
Branches 952 594 -358
==========================================
- Hits 212470 212453 -17
- Misses 93 100 +7
+ Partials 1 0 -1 |
Shinigami92
left a comment
There was a problem hiding this comment.
I'm a bit confused here 🤔
Why is it okay here to remove it directly without any runtime deprecation warning?
Also, is this just a missed left-over and we forgot to remove it once we build the PR?
Because it was never meant to be in a release. This is an artifact from the introduction of the base locale, AFAICT. |
Removes the unused
globalfaker instance that is only a copy of thebaseone.