feat(music): add additional genres

[jeremyhofer]

This PR is split off from #2620 where I originally added additional genres along with new album and artistName methods.

Genres were compiled primarily from these resources:

• https://www.musicgenreslist.com/
• https://en.wikipedia.org/wiki/List_of_music_genres_and_styles
• https://koop.org/shows/genres-definitions/
• https://www.musicgateway.com/blog/spotify/what-are-the-different-genres-of-music

Based on feedback in #2620 from the original set I added I tried to clean up some of the odd/awkward genres adopted from the sources, e.g. just specifying "Holiday" or "Classical" instead of listing some of the sub-types from the resources. Happy to clean up the list further if desired!

[jeremyhofer]

In addition to the call outs about Standup Comedy and Spoken Word, I cleaned up other questionable genres that were in the list, trying to keep it pure to music only. This included removing items related to activities like Study or Exercise, since really any music can be used for that.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.94%. Comparing base (1477958) to head (6a8bacc).

Additional details and impacted files

@@           Coverage Diff            @@
##             next    #2621    +/-   ##
========================================
  Coverage   99.93%   99.94%            
========================================
  Files        2960     2960            
  Lines      211366   211617   +251     
  Branches      604      953   +349     
========================================
+ Hits       211231   211499   +268     
+ Misses        135      114    -21     
- Partials        0        4     +4     

Files	Coverage Δ
src/locales/en/music/genre.ts	100.00% <100.00%> (ø)

... and 5 files with indirect coverage changes

[ST-DDT]

I'm not sure whether we should include genres like <any country> X.
What do the others think?

[jeremyhofer]

@ST-DDT I had similar thoughts on the country names. There were some examples where e.g. France and French were both included from the sources I compiled from. In that case I opted for French. Could do similar for other countries listed.

[matthewmayer]

I tend to agree that France or French is not really a genre.

If a French is performing rock, it's Rock. If it's a classical piece, it's Classical, rather than just lumping it under French.

So maybe let's remove all country/language genres.

[xDivisionByZerox]

Sorry for my late feedback. The list you provided is very comprehensive. Would it be better to organize the genres into "main" and "sub" categories? I can see people requesting the possibility of only getting "common" genres. For features like this we would need to introduce a breaking change. Is that something we should consider?

[matthewmayer]

Sorry for my late feedback. The list you provided is very comprehensive. Would it be better to organize the genres into "main" and "sub" categories? I can see people requesting the possibility of only getting "common" genres. For features like this we would need to introduce a breaking change. Is that something we should consider?

i'd say we dont really do that anywhere else. You can't request "common" first names or "common" dog breeds or "common" countries. There's no standard list of what a musical genre is.

[xDivisionByZerox]

i'd say we dont really do that anywhere else. You can't request "common" first names or "common" dog breeds or "common" countries. There's no standard list of what a musical genre is.

We have:

• commonFileExt
• commonFileName
• commonFileType

I see more reason to differenciate betrween common and sub music genres as some genres are literally described as "x is a subgenre of y". For example:

• Acid house (also simply known as just "acid") is a subgenre of house music [...]
• Death metal is an extreme subgenre of heavy metal music [...]

---

I'm just trying to think ahead to avoid potential breaking chages. If all of you think this is unnecessary I'm fine with that as well.

[ST-DDT]

Team Decision

• We will add this
• If we need a selection of common genres, then we can open a new issue

[netlify]

✅ Deploy Preview for fakerjs canceled.

Name	Link
🔨 Latest commit	6a8bacc
🔍 Latest deploy log	https://app.netlify.com/sites/fakerjs/deploys/6605aa3a6c3f75000931fe59