esm with tsup demonstration#2401
Merged
Shinigami92 merged 1 commit intoconvert-to-esmfrom Feb 16, 2024
Merged
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## convert-to-esm #2401 +/- ##
=================================================
Coverage ? 99.55%
=================================================
Files ? 2817
Lines ? 251199
Branches ? 1124
=================================================
Hits ? 250088
Misses ? 1082
Partials ? 29 |
Shinigami92
force-pushed
the
convert-to-esm
branch
from
6b79bae to
418fdfd
Compare
Shinigami92
added
the
do NOT merge yet
Shinigami92
force-pushed
the
esm-with-tsup-that-supports-cjs
branch
from
a021a8f to
fbefff7
Compare
Shinigami92
force-pushed
the
convert-to-esm
branch
from
418fdfd to
6b05b1c
Compare
Shinigami92
force-pushed
the
esm-with-tsup-that-supports-cjs
branch
from
fbefff7 to
3a00c1f
Compare
Shinigami92
force-pushed
the
convert-to-esm
branch
from
6b05b1c to
ed51481
Compare
Shinigami92
force-pushed
the
esm-with-tsup-that-supports-cjs
branch
from
3a00c1f to
1f151da
Compare
ST-DDT
removed
the
do NOT merge yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR shows that with tsup + the esm migration all tests are passing
So this is the combination of
together with outputting .cjs files instead of .esm
I also tested with the playground and everything works fine 🎉