Skip to content

feat(locale): fix wide month and add music for zh_CN#2380

Merged
Shinigami92 merged 4 commits intofaker-js:nextfrom
CoolPlayLin:new_music
Sep 10, 2023
Merged

feat(locale): fix wide month and add music for zh_CN#2380
Shinigami92 merged 4 commits intofaker-js:nextfrom
CoolPlayLin:new_music

Conversation

@CoolPlayLin
Copy link
Copy Markdown
Contributor

No description provided.

@CoolPlayLin CoolPlayLin requested a review from a team as a code owner September 8, 2023 13:18
@codecov
Copy link
Copy Markdown

codecov Bot commented Sep 8, 2023

Codecov Report

Merging #2380 (7e76b69) into next (ed71d64) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #2380      +/-   ##
==========================================
- Coverage   99.61%   99.61%   -0.01%     
==========================================
  Files        2786     2786              
  Lines      252710   252716       +6     
  Branches     1096     1096              
==========================================
+ Hits       251734   251738       +4     
- Misses        949      951       +2     
  Partials       27       27              
Files Changed Coverage Δ
src/locales/zh_CN/date/month.ts 100.00% <100.00%> (ø)
src/locales/zh_CN/music/song_name.ts 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@xDivisionByZerox xDivisionByZerox requested a review from a team September 9, 2023 20:20
@xDivisionByZerox xDivisionByZerox added c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs c: locale Permutes locale definitions m: date Something is referring to the date module m: music Something is referring to the music module p: 1-normal Nothing urgent labels Sep 9, 2023
Comment thread src/locales/zh_CN/music/song_name.ts
@CoolPlayLin CoolPlayLin changed the title feat(locale): Modified Something for zh_CN feat(locale): fix wide month & add music Sep 10, 2023
@CoolPlayLin CoolPlayLin removed their assignment Sep 10, 2023
@CoolPlayLin CoolPlayLin changed the title feat(locale): fix wide month & add music feat(locale): fix wide month and add music for zh_CN Sep 10, 2023
@ST-DDT ST-DDT requested a review from a team September 10, 2023 08:12
@ST-DDT ST-DDT requested a review from a team September 10, 2023 11:36
@Shinigami92 Shinigami92 enabled auto-merge (squash) September 10, 2023 11:43
@Shinigami92 Shinigami92 merged commit 501602b into faker-js:next Sep 10, 2023
@CoolPlayLin CoolPlayLin deleted the new_music branch September 16, 2023 00:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c: locale Permutes locale definitions c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs m: date Something is referring to the date module m: music Something is referring to the music module p: 1-normal Nothing urgent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants