-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
feat(commerce): Add method for generating ISBN-10 and ISBN-13 #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
d0b3bb3
Add ISBN method to commerce module
RobinvanderVliet e6d8bdb
Add unit tests for ISBN method
RobinvanderVliet c80951b
Merge branch 'next' into add-isbn
RobinvanderVliet f0c96b7
Improve variable names
RobinvanderVliet 20a8d6b
Add tests for ISBN method
RobinvanderVliet 68e181a
Merge branch 'next' into add-isbn
RobinvanderVliet 3e75ef1
Update snap file
RobinvanderVliet d48b747
Use `helpers.objectKey` instead of `number.int`
RobinvanderVliet 2b3ab5e
Remove obvious explicit type definition
RobinvanderVliet f605d3a
Validate ISBN with validator.js
RobinvanderVliet 639f7fa
Merge branch 'next' into add-isbn
RobinvanderVliet 84f30ba
Remove explicit type defintions
RobinvanderVliet 02a55ab
Simplify group rule selection
RobinvanderVliet ff1709f
Merge branch 'next' into add-isbn
RobinvanderVliet 2a6552f
Update `@since`
RobinvanderVliet 0d949ea
Merge branch 'next' into add-isbn
ST-DDT c401c11
Merge remote-tracking branch 'origin/next' into add-isbn
RobinvanderVliet 59ad9e2
Merge branch 'next' into add-isbn
RobinvanderVliet db28535
Merge branch 'next' into add-isbn
ST-DDT 3201b18
Merge branch 'next' into add-isbn
xDivisionByZerox File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.