-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
refactor!: remove dynamic locale switching support #1735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
48 commits
Select commit
Hold shift + click to select a range
74fa8eb
refactor!: remove locale changing
ST-DDT 8ff9c61
chore: remove broken code from tests
ST-DDT c1c86cd
chore: more test fixes
ST-DDT 6113065
chore: cleanup
ST-DDT fa9d4d8
chore: remove unused code
ST-DDT 174f7aa
chore: add lost comment again
ST-DDT b0c4e83
chore: improve email test
ST-DDT 49bb957
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 74dbb5f
chore: Faker class backwards compatibility
ST-DDT a8d1664
chore: export FakerOptions again
ST-DDT 8948d66
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 6880bd1
chore: explicitly throw for faker.random.locale
ST-DDT 95fdc56
docs: handle private methods
ST-DDT 1dc20a0
chore: cleanup
ST-DDT bcb10b2
chore: more cleanup
ST-DDT 245ee98
chore: stricter types in all_functional test
ST-DDT 78e866f
chore: merge main
ST-DDT 3b67585
chore: merge next
ST-DDT 179858a
chore: merge next
ST-DDT e6f36dd
chore: merge next
ST-DDT ea631fe
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 9a3fae2
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 02b40aa
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 3dc29e2
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT f5bf6b7
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 7332e1b
docs: update documentation
ST-DDT 23823ff
docs: add upgrade guide
ST-DDT 2623110
Merge remote-tracking branch 'origin/next' into refactor/remove-local…
ST-DDT cf5fed6
chore: commit missing files
ST-DDT 1e3c16f
docs: link to issue directly
ST-DDT dffc753
chore: apply suggestions and some fixes
ST-DDT 6387d52
chore: fix typo
ST-DDT 858020c
chore: apply suggestions
ST-DDT c5a4d00
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT af9f201
chore: apply suggetions
ST-DDT d5a1b56
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT aae21d7
chore: apply team decisions
ST-DDT 349dcfe
chore: repeat test
ST-DDT 00a07b3
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT d404b3b
chore: apply suggestions
ST-DDT 032ea64
Merge remote-tracking branch 'origin/next' into refactor/remove-local…
ST-DDT 45570c0
chore: apply suggestions
ST-DDT ad9acac
chore: apply suggestions
ST-DDT e0c6663
chore: apply suggestions
ST-DDT ed7a76e
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT 62e599e
chore: remove debug code
ST-DDT b166fff
chore: really revert debug code
ST-DDT f3b1484
Merge branch 'next' into refactor/remove-locale-changing
ST-DDT File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.