fix(date): don't allow parameters <= 0#1536
Merged
Shinigami92 merged 7 commits intonextfrom Nov 9, 2022
Merged
Conversation
Shinigami92
commented
Nov 7, 2022
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1536 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 2214 2214
Lines 238725 238741 +16
Branches 1015 1023 +8
=======================================
+ Hits 237869 237885 +16
Misses 835 835
Partials 21 21
|
ST-DDT
previously approved these changes
Nov 8, 2022
ST-DDT
reviewed
Nov 8, 2022
Member
Author
IMO this is not directly part of this issue. I would like to have this fixed to proceed with #1534. |
ST-DDT
approved these changes
Nov 8, 2022
ejcheng
approved these changes
Nov 8, 2022
xDivisionByZerox
approved these changes
Nov 9, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While working on #1534 I found this bug and extracted it to this PR.
Before this fix,
values === 0would be treated as falsy value and fallback to1.We want to prevent this behavior directly and now throw an error when the user tries to use values below or equals to 0.