Skip to content

refactor!: upgrade node minimum target#1494

Merged
ST-DDT merged 2 commits intonextfrom
upgrade-node-min-target
Oct 30, 2022
Merged

refactor!: upgrade node minimum target#1494
ST-DDT merged 2 commits intonextfrom
upgrade-node-min-target

Conversation

@Shinigami92
Copy link
Copy Markdown
Member

Based on https://github.blog/changelog/2022-10-24-npm-v9-0-0-released/#%E2%9A%A0%EF%B8%8F-notable-breaking-changes (and
image
)
it is safe to upgrade the min target of node to these versions
This might (or might not 🤷) result in slightly optimized bundle outputs.
But as a positive side-effect we force folks to push their node and npm to secure versions.

@Shinigami92 Shinigami92 added c: dependencies Pull requests that adds/updates a dependency c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs labels Oct 28, 2022
@Shinigami92 Shinigami92 self-assigned this Oct 28, 2022
@Shinigami92 Shinigami92 requested a review from a team as a code owner October 28, 2022 18:46
@codecov
Copy link
Copy Markdown

codecov Bot commented Oct 28, 2022

Codecov Report

Merging #1494 (c4eccbd) into next (9abfcfb) will decrease coverage by 0.00%.
The diff coverage is n/a.

❗ Current head c4eccbd differs from pull request most recent head cba3ccb. Consider uploading reports for the commit cba3ccb to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1494      +/-   ##
==========================================
- Coverage   99.63%   99.63%   -0.01%     
==========================================
  Files        2175     2165      -10     
  Lines      237613   237147     -466     
  Branches     1009     1021      +12     
==========================================
- Hits       236751   236285     -466     
  Misses        841      841              
  Partials       21       21              
Impacted Files Coverage Δ
src/modules/datatype/index.ts 99.12% <0.00%> (-0.01%) ⬇️
src/locales/ko/index.ts 100.00% <0.00%> (ø)
src/locales/ko/company/suffix.ts 100.00% <0.00%> (ø)
src/locales/ko/location/index.ts 100.00% <0.00%> (ø)
src/internal/mersenne/mersenne.ts 100.00% <0.00%> (ø)
src/locales/ko/word/adverb.ts
src/locales/ko/word/adjective.ts
src/locales/ko/date/month.ts
src/locales/ko/color/human.ts
src/locales/ko/date/index.ts
... and 6 more

@Shinigami92 Shinigami92 added the breaking change Cannot be merged when next version is not a major release label Oct 28, 2022
@ST-DDT ST-DDT requested review from a team October 28, 2022 21:10
@ST-DDT ST-DDT enabled auto-merge (squash) October 30, 2022 08:04
@ST-DDT ST-DDT merged commit 226d421 into next Oct 30, 2022
@ST-DDT ST-DDT deleted the upgrade-node-min-target branch November 8, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking change Cannot be merged when next version is not a major release c: dependencies Pull requests that adds/updates a dependency c: refactor PR that affects the runtime behavior, but doesn't add new features or fixes bugs

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

3 participants