feat(locale): extend Hebrew (he)#1257
Merged
Shinigami92 merged 3 commits intofaker-js:mainfrom Aug 16, 2022
Merged
Conversation
Shinigami92
changed the title
Codecov Report
@@ Coverage Diff @@
## main #1257 +/- ##
=========================================
Coverage 99.63% 99.63%
=========================================
Files 2156 2154 -2
Lines 237000 239941 +2941
Branches 1007 1009 +2
=========================================
+ Hits 236125 239065 +2940
- Misses 854 855 +1
Partials 21 21
|
ST-DDT
reviewed
Aug 11, 2022
Member
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
I reviewed half of this PR and will do the rest tomorrow.
It looks good so far, I only had one word that I couldn't very using google translate.
Member
|
Thanks for your contribution! |
ST-DDT
added
p: 1-normal
Shinigami92
changed the title
ST-DDT
approved these changes
Aug 13, 2022
ejcheng
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As a Hebrew speaker who had to use this great package, I found some issues with the Hebrew locales. In this PR, I tried to fix as many of those issues as possible and make the data generated in Hebrew more realistic.
Changes
Address
Buidling Number
I Added common Israeli pattern for semidetached house's Building numbers.
Cities
I Added a list of Israeli cities from our local MOI database.
Therefore I removed the prefix_city file.
Countries
I updated the list as it seemed to be missing many countries.
In addition, I updated the default country to 'Israel' (instead of 'State of Israel') (lit.)
State
I inserted the official regions of Israel to the list.
Streets
In Hebrew, there are no suffixes to street's name, so I replaced the suffix with prefix file that includes common prefixes.
In addition, I took a list of streets names from some of cities in Israel and added that to
street_name.tsDirection Abbreviation
I translated the values.
Cell Phones & Phone numbers
I added the Israeli patterns for Cell Phones and Phone numbers
Color
The translation had Niqqud although using Niqqud is very uncommon in modern Hebrew, so I removed it.
Music
Genres
I refined the translation of some of the genres
Names
First & Last Names
Some names appeared twice or had a suffix of the word 'Family' between parentheses. I also added missing white-spaces.
Prefix
I translated the values.