feat(system.networkInterface): add networkInterface faker#1133
Merged
Shinigami92 merged 8 commits intofaker-js:mainfrom Aug 4, 2022
Merged
feat(system.networkInterface): add networkInterface faker#1133Shinigami92 merged 8 commits intofaker-js:mainfrom
Shinigami92 merged 8 commits intofaker-js:mainfrom
Conversation
ST-DDT
reviewed
Jul 8, 2022
Codecov Report
@@ Coverage Diff @@
## main #1133 +/- ##
=======================================
Coverage 99.62% 99.62%
=======================================
Files 2155 2155
Lines 236831 236900 +69
Branches 979 989 +10
=======================================
+ Hits 235942 236011 +69
Misses 868 868
Partials 21 21
|
ST-DDT
added
c: feature
ST-DDT
added
s: needs decision
Member
|
Preview: ✅
|
ST-DDT
previously approved these changes
Jul 8, 2022
Shinigami92
previously approved these changes
Jul 8, 2022
Member
Shinigami92
left a comment
Shinigami92
left a comment
There was a problem hiding this comment.
I'm personally not really happy what prettier does for the formatting here but that is not the authors problem
Also the test regex are very heavy, but they work
The PR works, so I will approve
ejcheng
requested changes
Aug 2, 2022
Member
ejcheng
left a comment
ejcheng
left a comment
There was a problem hiding this comment.
Please fix the tests, some are running red.
Shinigami92
reviewed
Aug 2, 2022
ST-DDT
previously approved these changes
Aug 2, 2022
Shinigami92
approved these changes
Aug 4, 2022
ST-DDT
approved these changes
Aug 4, 2022
ejcheng
approved these changes
Aug 4, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I built this to use in one of my own projects, based on the SystemD predictable network interface device names schema (although this is likely the antithesis of that 😛 ). Figured it might be worth sharing, but if it's too niche then no hard feelings 😄