feat: migrate hacker#81
Merged
Shinigami92 merged 2 commits intomigrate-to-typescriptfrom Jan 14, 2022
Merged
Conversation
Member
Author
|
@HonzaMac I have not added return types yet, cause the bodies of them are not clear right now what they really return |
27 tasks
Shinigami92
force-pushed
the
migrate-hacker
branch
from
e2e3a30 to
45143b4
Compare
Shinigami92
force-pushed
the
migrate-to-typescript
branch
from
0e7e1ba to
64b8db8
Compare
Shinigami92
force-pushed
the
migrate-hacker
branch
from
45143b4 to
0556c7b
Compare
Shinigami92
force-pushed
the
migrate-to-typescript
branch
2 times, most recently
from
24a00c3 to
3db7e8b
Compare
Shinigami92
force-pushed
the
migrate-hacker
branch
from
0556c7b to
fbf61ec
Compare
Shinigami92
force-pushed
the
migrate-to-typescript
branch
from
fc36e2f to
7b02094
Compare
prisis
approved these changes
Jan 13, 2022
Shinigami92
force-pushed
the
migrate-hacker
branch
from
fbf61ec to
e73890c
Compare
Shinigami92
force-pushed
the
migrate-hacker
branch
from
e73890c to
bf58d10
Compare
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
Shinigami92
added a commit
that referenced
this pull request
Jan 14, 2022
damienwebdev
pushed a commit
that referenced
this pull request
Jan 14, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is based on top of other TS migrations like #72
We need to migrate
helperscause this module depends on itAlso this module needs the
definitionsstructure 🤔 I think we should try to create this dynamically instead of like it is currently (#84)test with
npm run build && npx mocha test/hacker.unit.js