chore!: switch to tsup

[Shinigami92]

This PR switches the build process from using esbuild nativly to tsup (which uses esbuild under the hood).
It simplifies the config and prepares for easier migration later to esm (see #2261)

• chore: convert to esm #2261

And even better! It magically reduces the dist folder content:

esbuild	->	tsup
14.4 MiB (15,053,311)	->	10.6 MiB (11,066,749)
5,715 files	->	3,072 files
1,210 sub-folders	->	605 sub-folders

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (44d698e) 99.56% compared to head (a9d26a8) 99.55%.

Additional details and impacted files

@@            Coverage Diff             @@
##             next    #2391      +/-   ##
==========================================
- Coverage   99.56%   99.55%   -0.01%     
==========================================
  Files        2817     2817              
  Lines      251199   251199              
  Branches     1129     1125       -4     
==========================================
- Hits       250101   250088      -13     
- Misses       1069     1111      +42     
+ Partials       29        0      -29     

see 30 files with indirect coverage changes

[ST-DDT]

And even better! It magically reduces the dist folder content:
esbuild -> tsup
14.4 MiB (15,053,311) -> 10.6 MiB (11,066,749)
5,715 files -> 3,072 files
1,210 sub-folders -> 605 sub-folders

Mind giving some details what/why files/data are now missing?

[Shinigami92]

Mind giving some details what/why files/data are now missing?

I was hoping you'd want to check out the PR and discover it for yourself, but okay, I can spoil it for you:

As you can already see in the package.json

faker/package.json

Lines 31 to 53 in 5445afe

	"main": "dist/index.js",
	"module": "dist/index.mjs",
	"types": "index.d.ts",
	"typesVersions": {
	">=4.0": {
	"*": [
	"dist/types/*"
	]
	}
	},
	"exports": {
	".": {
	"types": "./dist/types/index.d.ts",
	"require": "./dist/index.js",
	"import": "./dist/index.mjs"
	},
	"./locale/*": {
	"types": "./dist/types/locale/*.d.ts",
	"require": "./dist/locale/*.js",
	"import": "./dist/locale/*.mjs"
	},
	"./package.json": "./package.json"
	},

the main, module and exports fields have changed.
So the files are no longer in separate folders but side-by-side.
This already splits the sub-folders count into half.

The other changes comes from (🥁): tsup supports splitting for cjs 🎉

[ST-DDT]

Well, not only does tsup support splitting, but also chunking (Hence the reduced number of files for cjs).

So for cjs users it is no longer possible to import directly from .../dist/cjs/locales/af_ZA/cell_phone/formats.js.
(Not that I would recommend doing so anyway)
Do we expect any of our users to use that kind of import paths?

[Shinigami92]

Well, not only does tsup support splitting, but also chunking (Hence the reduced number of files for cjs).

// chunking == splitting

So for cjs users it is no longer possible to import directly from .../dist/cjs/locales/af_ZA/cell_phone/formats.js. (Not that I would recommend doing so anyway) Do we expect any of our users to use that kind of import paths?

No! Anything not defined in exports is NOT supported.

[matthewmayer]

Well, not only does tsup support splitting, but also chunking (Hence the reduced number of files for cjs).

// chunking == splitting

So for cjs users it is no longer possible to import directly from .../dist/cjs/locales/af_ZA/cell_phone/formats.js. (Not that I would recommend doing so anyway) Do we expect any of our users to use that kind of import paths?

No! Anything not defined in exports is NOT supported.

while its not supported, its still a breaking change, so i think it should land in 9.0

[Shinigami92]

I checked if it is viable to ship sourcemaps, but hell no 😆

// With sourcemaps:
22.0 MiB (23,026,364)
580 files, 610 sub-folders

// Without sourcemaps:
10.0 MiB (10,437,487)
290 files, 610 sub-folders

12 MiB is NOT worth it 😬

[Shinigami92]

@ST-DDT already approved a week ago and only a rebase were done since then
We count this a one-week approval by only one maintainer, but dont violate our merge rules