feat(commerce): Add method for generating ISBN-10 and ISBN-13#2240
Merged
ST-DDT merged 20 commits intofaker-js:nextfrom Sep 10, 2023
RobinvanderVliet:add-isbn
Merged
feat(commerce): Add method for generating ISBN-10 and ISBN-13#2240ST-DDT merged 20 commits intofaker-js:nextfrom RobinvanderVliet:add-isbn
ST-DDT merged 20 commits intofaker-js:nextfrom
RobinvanderVliet:add-isbn
Conversation
xDivisionByZerox
added
c: feature
ST-DDT
added
the
s: waiting for user interest
ST-DDT
reviewed
Jul 9, 2023
Member
ST-DDT
left a comment
ST-DDT
left a comment
There was a problem hiding this comment.
Please note that the associated issue is marked as waiting for user interest, so this PR might not be merged immediately.
Closed
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #2240 +/- ##
========================================
Coverage 99.60% 99.61%
========================================
Files 2786 2786
Lines 252522 252674 +152
Branches 1083 1096 +13
========================================
+ Hits 251529 251699 +170
+ Misses 966 948 -18
Partials 27 27
|
ST-DDT
reviewed
Jul 19, 2023
ST-DDT
previously approved these changes
Jul 20, 2023
Co-authored-by: ST-DDT <ST-DDT@gmx.de>
ST-DDT
previously approved these changes
Jul 20, 2023
xDivisionByZerox
added
p: 1-normal
Member
|
Team decision We accept this feature request. @RobinvanderVliet Please resolve to merge conflicts so we can open it for review. |
Member
|
@RobinvanderVliet Could you please fix the merge conflicts? |
Contributor
Author
|
I resolved the merge conflicts! |
ST-DDT
approved these changes
Aug 14, 2023
xDivisionByZerox
approved these changes
Sep 9, 2023
Member
xDivisionByZerox
left a comment
xDivisionByZerox
left a comment
There was a problem hiding this comment.
I’m considering the use of a strategy pattern to improve the maintainability of the changed code. However, I have decided to accept the current implementation.
ejcheng
approved these changes
Sep 9, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first pull request contributing some actual code to this project, so any feedback is welcome!
This merge request resolves issue #2196.