refactor!: remove dynamic locale switching support#1735
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## next #1735 +/- ##
==========================================
- Coverage 99.64% 99.62% -0.02%
==========================================
Files 2355 2356 +1
Lines 236763 236565 -198
Branches 1158 1192 +34
==========================================
- Hits 235919 235678 -241
- Misses 822 865 +43
Partials 22 22
|
|
@matthewmayer do you have any more reviews you want to have into the PR before merging? |
sorry my bad i didnt realise that blocked merge. approved now. I have some further ideas for improving migration guide but that can be saved for a seperate PR. |
|
🎉 I will try to find some time the next days to address #1748 again |
Closes #1340
Removes the ability to change the locale on existing Faker instances.
New Features
en_AU_ocker)allLocales.en_AU_ocker)fakerEN_AU_ocker)allFakers.en_AU_ocker)en_AU_ocker->en_AU->en( ->enif not already present ( ->globallater))Changed Features
fakerinstance is nowenonlyLost Features
ToDos for later PRs
globallocale data into own locale (Add global locale #1441)findFaker(locale: string): Fakermethod ???