Prepend openapi! in any case - #128
Merged
Merged
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Codecov Report
@@ Coverage Diff @@
## master #128 +/- ##
==========================================
+ Coverage 96.63% 96.88% +0.24%
==========================================
Files 14 14
Lines 416 417 +1
==========================================
+ Hits 402 404 +2
+ Misses 14 13 -1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
If you run tests with Minitest at themoment, but without the environment variable `OPENAPI`, you are greeted with an error message. `undefined method `openapi!' for Api::V0::SomeControllerTest:Class (NoMethodError)` This is because the current code adds the `openapi!` method only if `OPENAPI` environment variable is set. This commit modifies the loading logic, always requiring the `minitest` hooks class to be loaded if `Minitest` constant is defined, to avoid issues with RSpec. Then, the `openapi?` and `openapi!` methods are always prepended to `Minitest::Test`, while the modified `run` method and the `after_run` hook are only activated when `OPENAPI` environment variable is set.
The alternative to this approach would be to remove the check for `Object.const_defined?('Minitest')`, but I assume in environments where you only have RSpec, not Minitest (like when you use another framework than Rails), this would not work.
andyundso
marked this pull request as ready for review
July 26, 2023 13:03
Owner
|
Thanks. Makes sense to me. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you run tests with Minitest at the moment, but without the environment variable
OPENAPI, you are greeted with an error message.This is because the current code adds the
openapi!method only ifOPENAPIenvironment variable is set.This commit modifies the loading logic, always requiring the
minitesthooks class to be loaded ifMinitestconstant is defined, to avoid issues with RSpec. Then, theopenapi?andopenapi!methods are always prepended toMinitest::Test, while the modifiedrunmethod and theafter_runhook are only activated whenOPENAPIenvironment variable is set.