fix(sqlite): populate SelectStmt.SortClause during AST conversion#1
Merged
celso-alexandre merged 1 commit intoJun 12, 2026
Conversation
SQLite ORDER BY clauses were parsed but not propagated into SelectStmt.SortClause during AST conversion. This caused ORDER BY expressions, including sqlc.switch(...) and function calls such as upper(name), to be invisible to later AST visitors and macro recognition passes. Co-authored-by: OpenAI Codex <codex@openai.com>
fahmifan
force-pushed
the
feat/sqlc-switch-sqlite-order-by-support
branch
from
ae22719 to
f7bf98b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SQLite
ORDER BYclauses were parsed but not propagated intoSelectStmt.SortClauseduring AST conversion.This caused
ORDER BYexpressions, includingsqlc.switch(...)and function calls such asupper(name), to be invisible to later AST visitors and macro recognition passes.