Swip 048 - Pushsync forwarding from in-AOR full nodes to closest nodes#97
Open
lat-murmeldjur wants to merge 1 commit into
Open
Swip 048 - Pushsync forwarding from in-AOR full nodes to closest nodes#97lat-murmeldjur wants to merge 1 commit into
lat-murmeldjur wants to merge 1 commit into
Conversation
lat-murmeldjur
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pushsync should keep a chunk moving toward the closest currently selectable reachable peer. A full node that is inside the chunk's area of responsibility will store the chunk locally, but a local receipt should be a time bounded fallback, not the first result returned upstream.
This SWIP builds on
bee#5390, which addresses out-of-depth storing, shallow receipts, and falseChunkSyncedreporting. The additional change is limited to forwarder behaviour: an in-AOR full node should not stop the push path while normal forwarding can still progress, andErrWantSelfshould not bypass the overdraft refresh path when temporary accounting skips may soon clear.